Repository navigation
Fix/74816 - Next button on Initial page reopens same page when Workflows settings are disabled - #76727
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product changes LGTM
|
@dmkt9 Could you please update the preconditions in the test steps for better clarity? What does it mean to turn off Add approvals and Make or track payments? For Add approvals, the options are: Submit and Close, Submit and Approve, and Advanced Approval.
For Make or track payments, the options are: Direct, Indirect, None.
|
|
@dmkt9 Please ignore the previous message. I was looking at the workflow settings on OD instead of ND. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari76727-web.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.74-0 🚀
|
|
This was reverted because of the regression found #76727 |
Fix/74816 - Next button on Initial page reopens same page when Workflows settings are disabled (cherry picked from commit 836f696) (cherry-picked to staging by AndrewGable)
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|






Explanation of Change
This PR fixes a bug where clicking the Next button on the money request page, when opened from the quick expense shortcut button, would reopen the initial page.
Fixed Issues
$ #74816
PROPOSAL: #74816 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition: Turn off Submission frequency, Add approvals and Make or track payments in Workflows settings.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mwed.mp4
MacOS: Chrome / Safari
mac.safari.mp4